http2: improve errors thrown in header validation #16718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
errors
joyeecheung
commented
Nov 3, 2017
| @@ -837,7 +837,7 @@ requests and responses. | |||
| <a id="ERR_HTTP2_INVALID_HEADER_VALUE"></a> | |||
| ### ERR_HTTP2_INVALID_HEADER_VALUE | |||
|
|
|||
| Used to indicate that an invalid HTTP/2 header value has been specified. | |||
| Used to indicate that an invalid HTTP2 header value has been specified. | |||
There was a problem hiding this comment.
Uh, accidental...can be fixed later.
apapirovski
approved these changes
Nov 3, 2017
jasnell
approved these changes
Nov 3, 2017
lpinca
approved these changes
Nov 5, 2017
| err = new errors.TypeError('ERR_HTTP2_INVALID_HEADER_VALUE', value, name); | ||
| } | ||
| if (err !== undefined) { | ||
| Error.captureStackTrace(err, assertValidHeader); |
There was a problem hiding this comment.
Is there a particular reason to remove assertValidHeader from the stack trace?
There was a problem hiding this comment.
@lpinca I don't think that frame adds more value to the stacktrace because you can easily tell which line it would be by the error thrown, and the error codes themselves are clear enough to show the reason. Adding one more frame just expose more internal details that the user should not worry about..
There was a problem hiding this comment.
because you can easily tell which line it would be by the error thrown
Yes, but it should be inferred and it requires a little more effort. Internal details are useful for everyone when debugging. Anyway no problem, I can live with it :)
joyeecheung
added a commit
that referenced
this pull request
Nov 6, 2017
PR-URL: #16718 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 11a9f36, thanks! |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
PR-URL: nodejs#16718 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #16718 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
gibfahn
added a commit
that referenced
this pull request
Dec 5, 2017
Notable Changes: - **console**: - avoid adding infinite error listeners (Matteo Collina) [#16770](https://github.com/nodejs/n de/pull/16770) - **http2**: - improve errors thrown in header validation (Joyee Cheung) [#16718](https://github.com/nodej s/node/pull/16718) PR-URL: #17204
gibfahn
added a commit
that referenced
this pull request
Dec 5, 2017
Notable Changes: - **console**: - avoid adding infinite error listeners (Matteo Collina) [#16770](https://github.com/nodejs/n de/pull/16770) - **http2**: - improve errors thrown in header validation (Joyee Cheung) [#16718](https://github.com/nodej s/node/pull/16718) PR-URL: #17204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously #16715
This PR:
ERR_HTTP2_INVALID_HEADER_VALUEfor debug-ability as [REQUEST] Better Errors in http validate headers #16714 suggests. Before it'sValue must not be undefined or null, after it'sInvalid value "undefined" for header "test". If the user is setting the header in a loop this would be much more useful.Error.captureStackTraceto exclude the validation functions from the stack traceChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2